Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hidden collections toggle for create a gallery page #457

Merged
merged 42 commits into from
Nov 20, 2023

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Nov 15, 2023

[galleries] hidden collections still show up when creating gallery

Summary

  • MyGalleryCollectionController has been updated and it now checks if showHidden is in request and it will filter the hidden collections for the user.
  • useGalleryNfts hook has been updated. It now passes showHidden to the BE.
  • Typing for methods in GalleryNftsState has been updated. They now support showHidden as a param.
  • NftHiddenCollectionsToggle component has been created. It displays the switch input and its label, according to the UI. It supports light and dark modes, and also mobile version has been added.
  • Unit tests for the implemented components have been updated.
  • New translations for the implemented texts.

Steps to reproduce

  1. Run the app in local or testing_e2e mode.
  2. Make sure your testing wallet has at least 2 NFTs from different collections.
  3. Go to /collections page and hide some collections.
  4. Click on Create a gallery button.
  5. Now, try to add some NFTs for your gallery.
  6. Toggle on the Show hidden collections switch and see the magic ✨
Screen.Recording.2023-11-15.at.14.20.49.mov

Screenshots

  1. Create a Gallery button in My galleries page, when having at least 1 created gallery and all your collections hidden.
image
  1. Placeholder message when having 0 galleries and all your collections hidden.
image

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • I added a storybook entry for the component that was added (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo added this to the TBD milestone Nov 16, 2023
Copy link
Contributor

@alfonsobries alfonsobries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the ticket Rok mentions "This option is not visible to users who don't have any hidden collections." but I see the option

image

@alfonsobries alfonsobries marked this pull request as draft November 16, 2023 16:07
@patricio0312rev patricio0312rev marked this pull request as ready for review November 16, 2023 23:40
@ItsANameToo ItsANameToo modified the milestones: TBD, 0.12.0 Nov 17, 2023
Copy link
Contributor

@goga-m goga-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @patricio0312rev 💯

@goga-m goga-m merged commit 422fb7c into develop Nov 20, 2023
16 checks passed
@goga-m goga-m deleted the feat/hidden-collections-toggle-for-create-gallery-page branch November 20, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants