-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hidden collections toggle for create a gallery page #457
Merged
goga-m
merged 42 commits into
develop
from
feat/hidden-collections-toggle-for-create-gallery-page
Nov 20, 2023
Merged
feat: hidden collections toggle for create a gallery page #457
goga-m
merged 42 commits into
develop
from
feat/hidden-collections-toggle-for-create-gallery-page
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no collections available
patricio0312rev
requested review from
samharperpittam and
boldninja
as code owners
November 16, 2023 12:44
alfonsobries
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… of https://github.com/ArdentHQ/dashbrd into feat/hidden-collections-toggle-for-create-gallery-page
alfonsobries
approved these changes
Nov 17, 2023
alfonsobries
approved these changes
Nov 17, 2023
goga-m
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix @patricio0312rev 💯
9 tasks
goga-m
deleted the
feat/hidden-collections-toggle-for-create-gallery-page
branch
November 20, 2023 13:52
crnkovic
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[galleries] hidden collections still show up when creating gallery
Summary
MyGalleryCollectionController
has been updated and it now checks ifshowHidden
is in request and it will filter the hidden collections for the user.useGalleryNfts
hook has been updated. It now passesshowHidden
to the BE.GalleryNftsState
has been updated. They now supportshowHidden
as a param.NftHiddenCollectionsToggle
component has been created. It displays the switch input and its label, according to the UI. It supports light and dark modes, and also mobile version has been added.Steps to reproduce
local
ortesting_e2e
mode./collections
page and hide some collections.Create a gallery
button.Show hidden collections
switch and see the magic ✨Screen.Recording.2023-11-15.at.14.20.49.mov
Screenshots
Create a Gallery
button inMy galleries
page, when having at least 1 created gallery and all your collections hidden.Checklist